qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/16] Revert "Revert "arm: tcg: Adhere to SMCCC 1.3 section


From: Richard Henderson
Subject: Re: [PATCH 10/16] Revert "Revert "arm: tcg: Adhere to SMCCC 1.3 section 5.2""
Date: Mon, 31 Jan 2022 17:57:46 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 1/28/22 02:46, Peter Maydell wrote:
Now that we have arranged for all the affected board models
to not enable the PSCI emulation if they are running guest code
at EL3, we can revert commit 4825eaae4fdd56fba0f, thus
reinstating commit 9fcd15b9193e819b, without bringing back the
regressions that caused us to revert it.

For clarity, here is the original commit message of 9fcd15b9193e819b:

The SMCCC 1.3 spec section 5.2 says

   The Unknown SMC Function Identifier is a sign-extended value of (-1)
   that is returned in the R0, W0 or X0 registers. An implementation must
   return this error code when it receives:

     * An SMC or HVC call with an unknown Function Identifier
     * An SMC or HVC call for a removed Function Identifier
     * An SMC64/HVC64 call from AArch32 state

To comply with these statements, let's always return -1 when we encounter
an unknown HVC or SMC call.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  target/arm/psci.c | 35 ++++++-----------------------------
  1 file changed, 6 insertions(+), 29 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]