qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/16] hw/arm/versal: Let boot.c handle PSCI enablement


From: Richard Henderson
Subject: Re: [PATCH 07/16] hw/arm/versal: Let boot.c handle PSCI enablement
Date: Mon, 31 Jan 2022 17:50:59 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 1/28/22 02:46, Peter Maydell wrote:
Instead of setting the CPU psci-conduit and start-powered-off
properties in the xlnx-versal-virt board code, set the arm_boot_info
psci_conduit field so that the boot.c code can do it.

This will fix a corner case where we were incorrectly enabling PSCI
emulation when booting guest code into EL3 because it was an ELF file
passed to -kernel.  (EL3 guest code started via -bios, -pflash, or
the generic loader was already being run with PSCI emulation
disabled.)

Note that EL3 guest code has no way to turn on the secondary CPUs
because there's no emulated power controller, but this was already
true for EL3 guest code run via -bios, -pflash, or the generic
loader.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  include/hw/arm/xlnx-versal.h | 1 -
  hw/arm/xlnx-versal-virt.c    | 6 ++++--
  hw/arm/xlnx-versal.c         | 5 +----
  3 files changed, 5 insertions(+), 7 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]