qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] hw/sensor: add Intersil ISL69260 device model


From: Peter Maydell
Subject: Re: [PATCH 3/5] hw/sensor: add Intersil ISL69260 device model
Date: Thu, 27 Jan 2022 19:39:18 +0000

On Thu, 6 Jan 2022 at 23:19, Titus Rwantare <titusr@google.com> wrote:
>
> Signed-off-by: Titus Rwantare <titusr@google.com>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> ---
>  MAINTAINERS                   |   3 +
>  hw/arm/Kconfig                |   1 +
>  hw/sensor/Kconfig             |   5 +
>  hw/sensor/isl_pmbus.c         | 210 +++++++++++++++++++
>  hw/sensor/meson.build         |   1 +
>  include/hw/sensor/isl_pmbus.h |  50 +++++
>  tests/qtest/isl_pmbus-test.c  | 381 ++++++++++++++++++++++++++++++++++
>  tests/qtest/meson.build       |   1 +
>  8 files changed, 652 insertions(+)
>  create mode 100644 hw/sensor/isl_pmbus.c
>  create mode 100644 include/hw/sensor/isl_pmbus.h
>  create mode 100644 tests/qtest/isl_pmbus-test.c
>



> +static uint8_t isl_pmbus_read_byte(PMBusDevice *pmdev)
> +{
> +    qemu_log_mask(LOG_GUEST_ERROR,
> +                  "%s: reading from unsupported register: 0x%02x\n",
> +                  __func__, pmdev->code);
> +    return 0xFF;
> +}
> +
> +static int isl_pmbus_write_data(PMBusDevice *pmdev, const uint8_t *buf,
> +                              uint8_t len)
> +{
> +    qemu_log_mask(LOG_GUEST_ERROR,
> +                  "%s: write to unsupported register: 0x%02x\n",
> +                  __func__, pmdev->code);
> +    return 0xFF;
> +}

This device appears to have no implemented guest visible
interface at all, and yet it has a lot of object properties.
What's going on here ?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]