[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] hw/i2c: pmbus updates
From: |
Peter Maydell |
Subject: |
Re: [PATCH 1/5] hw/i2c: pmbus updates |
Date: |
Thu, 27 Jan 2022 19:36:30 +0000 |
On Thu, 6 Jan 2022 at 23:16, Titus Rwantare <titusr@google.com> wrote:
>
> - add vout min register
> - add PEC unsupported warning to pmbus_device class
> - guard against out of range pmbus page accesses
>
> Signed-off-by: Titus Rwantare <titusr@google.com>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
Hi; these different changes should be split up into separate
patches, please. Each patch should do one thing and only one.
> ---
> MAINTAINERS | 12 ++++-
> hw/i2c/pmbus_device.c | 88 +++++++++++++++++++++++++++++++----
> include/hw/i2c/pmbus_device.h | 3 ++
> 3 files changed, 92 insertions(+), 11 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f871d759fd..6349e3da1f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2790,7 +2790,7 @@ R: Paolo Bonzini <pbonzini@redhat.com>
> R: Bandan Das <bsd@redhat.com>
> R: Stefan Hajnoczi <stefanha@redhat.com>
> R: Thomas Huth <thuth@redhat.com>
> -R: Darren Kenny <darren.kenny@oracle.com>
> +R: Darren Kenny <darren.kenny@oracle.com>
> R: Qiuhao Li <Qiuhao.Li@outlook.com>
> S: Maintained
> F: tests/qtest/fuzz/
Looks like the whitespace-change again, same as the other patch.
thanks
-- PMM