Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

[David Hildenbrand]

On 18.11.21 11:28, Jonathan Cameron wrote:
> On Wed, 17 Nov 2021 19:08:28 +0100
> David Hildenbrand <david@redhat.com> wrote:
> 
>> On 17.11.21 15:30, Jonathan Cameron wrote:
>>> On Tue, 16 Nov 2021 12:11:29 +0100
>>> David Hildenbrand <david@redhat.com> wrote:
>>>   
>>>>>>
>>>>>> Examples include exposing HBM or PMEM to the VM. Just like on real HW,
>>>>>> this memory is exposed via cpu-less, special nodes. In contrast to real
>>>>>> HW, the memory is hotplugged later (I don't think HW supports hotplug
>>>>>> like that yet, but it might just be a matter of time).    
>>>>>
>>>>> I suppose some of that maybe covered by GENERIC_AFFINITY entries in SRAT
>>>>> some by MEMORY entries. Or nodes created dynamically like with normal
>>>>> hotplug memory.
>>>>>     
>>>   
>>
>> Hi Jonathan,
>>
>>> The naming of the define is unhelpful.  GENERIC_AFFINITY here corresponds
>>> to Generic Initiator Affinity.  So no good for memory. This is meant for
>>> representation of accelerators / network cards etc so you can get the NUMA
>>> characteristics for them accessing Memory in other nodes.
>>>
>>> My understanding of 'traditional' memory hotplug is that typically the
>>> PA into which memory is hotplugged is known at boot time whether or not
>>> the memory is physically present.  As such, you present that in SRAT and 
>>> rely
>>> on the EFI memory map / other information sources to know the memory isn't
>>> there.  When it is hotplugged later the address is looked up in SRAT to 
>>> identify
>>> the NUMA node.  
>>
>> in virtualized environments we use the SRAT only to indicate the hotpluggable
>> region (-> indicate maximum possible PFN to the guest OS), the actual present
>> memory+PXM assignment is not done via SRAT. We differ quite a lot here from
>> actual hardware I think.
>>
>>>
>>> That model is less useful for more flexible entities like virtio-mem or
>>> indeed physical hardware such as CXL type 3 memory devices which typically
>>> need their own nodes.
>>>
>>> For the CXL type 3 option, currently proposal is to use the CXL table 
>>> entries
>>> representing Physical Address space regions to work out how many NUMA nodes
>>> are needed and just create extra ones at boot.
>>> https://lore.kernel.org/linux-cxl/163553711933.2509508.2203471175679990.stgit@dwillia2-desk3.amr.corp.intel.com
>>>
>>> It's a heuristic as we might need more nodes to represent things well kernel
>>> side, but it's better than nothing and less effort that true dynamic node 
>>> creation.
>>> If you chase through the earlier versions of Alison's patch you will find 
>>> some
>>> discussion of that.
>>>
>>> I wonder if virtio-mem should just grow a CDAT instance via a DOE?
>>>
>>> That would make all this stuff discoverable via PCI config space rather 
>>> than ACPI
>>> CDAT is at:
>>> https://uefi.org/sites/default/files/resources/Coherent%20Device%20Attribute%20Table_1.01.pdf
>>> but the table access protocol over PCI DOE is currently in the CXL 2.0 spec
>>> (nothing stops others using it though AFAIK).
>>>
>>> However, then we'd actually need either dynamic node creation in the OS, or
>>> some sort of reserved pool of extra nodes.  Long term it may be the most
>>> flexible option.  
>>
>>
>> I think for virtio-mem it's actually a bit simpler:
>>
>> a) The user defined on the QEMU cmdline an empty node
>> b) The user assigned a virtio-mem device to a node, either when 
>>    coldplugging or hotplugging the device.
>>
>> So we don't actually "hotplug" a new node, the (possible) node is already 
>> known
>> to QEMU right when starting up. It's just a matter of exposing that fact to 
>> the
>> guest OS -- similar to how we expose the maximum possible PFN to the guest 
>> OS.
>> It's seems to boild down to an ACPI limitation.
>>
>> Conceptually, virtio-mem on an empty node in QEMU is not that different from
>> hot/coldplugging a CPU to an empty node or hot/coldplugging a DIMM/NVDIMM to
>> an empty node. But I guess it all just doesn't work with QEMU as of now.
> 
> A side distraction perhaps, but there is a code first acpi proposal to add
> a 'softer' form of CPU hotplug 
> https://bugzilla.tianocore.org/show_bug.cgi?id=3706
> 
> Whilst the reason for that proposal was for arm64 systems where there is no 
> architected
> physical hotplug, it might partly solve the empty node question for CPUs.  
> They won't
> be empty, there will simply be CPUs that are marked as 'Online capable'.
> 
>>
>> In current x86-64 code, we define the "hotpluggable region" in 
>> hw/i386/acpi-build.c via
>>
>>      build_srat_memory(table_data, machine->device_memory->base,
>>                        hotpluggable_address_space_size, nb_numa_nodes - 1,
>>                        MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
>>
>> So we tell the guest OS "this range is hotpluggable" and "it contains to
>> this node unless the device says something different". From both values we
>> can -- when under QEMU -- conclude the maximum possible PFN and the maximum
>> possible node. But the latter is not what Linux does: it simply maps the last
>> numa node (indicated in the memory entry) to a PXM
>> (-> drivers/acpi/numa/srat.c:acpi_numa_memory_affinity_init()).
> yeah.  There is nothing in ACPI that says there can't be holes in the node 
> numbering
> so Linux does a remapping as you point out.
> 
>>
>>
>> I do wonder if we could simply expose the same hotpluggable range via 
>> multiple nodes:
> 
> Fairly sure the answer to this is no.  You'd have to indicate different 
> ranges and
> then put the virtio-mem in the right one. 

And I repeat, this is in no way different to DIMMs/NVDIMMs. We cannot predict
the future when hotplugging DIMMS/NVDIMMs/virtio-mem/... to some node later. We 
only
have access to that information when coldplugging devices, but even a
hotunplug+hotplug can change that info. Whatever we expose via ACPI is moot
already and just a hint to the guest OS "maximum possible PFN".

We've been abusing ACPI hotpluggable region for years for virt DIMM hotplug,
putting it to some fantasy node and having it just work with hotplug of
DIMMs/NVDIMMs. The only issue we have is empty nodes. We differ from real
HW already significantly (especially, never exposing DIMMs via e820 to
the guest, which I call a feature and not a bug).

> Now I can't actually find anywhere in the
> ACPI spec that says that but I'm 99% sure Linux won't like and I'm fairly 
> sure if we
> query it with ACPI folks the answer will be a no you can't don't that.

I didn't find anything that contradicts it in the spec as well. It's not really
specified what's allowed and what's not :)

FWIW, the code I shared works with 5.11.12-300.fc34.x86_64 inside the guest 
flawlessly.

#! /bin/bash
sudo build/qemu-system-x86_64 \
    --enable-kvm \
    -m 8G,maxmem=32G,slots=1 \
    -object memory-backend-memfd,id=mem,size=8G \
    -numa node,nodeid=0,memdev=mem,cpus=0-4 \
    -numa node,nodeid=1 -numa node,nodeid=2 \
    -numa node,nodeid=3 -numa node,nodeid=4 \
    -smp sockets=2,cores=4 \
    -nographic \
    -nodefaults \
    -net nic -net user \
    -chardev stdio,nosignal,id=serial \
    -hda Fedora-Cloud-Base-34-1.2.x86_64.qcow2 \
    -cdrom /home/dhildenb/git/cloud-init/cloud-init.iso \
    -device isa-serial,chardev=serial \
    -chardev socket,id=monitor,path=/var/tmp/mon_src,server,nowait \
    -mon chardev=monitor,mode=readline \
    -object memory-backend-memfd,id=mem0,size=8G \
    -device virtio-mem-pci,id=vmem0,memdev=mem0,node=1,requested-size=128M \
    -object memory-backend-memfd,id=mem1,size=8G \
    -device virtio-mem-pci,id=vmem1,memdev=mem1,node=2,requested-size=128M \
    -object memory-backend-memfd,id=mem2,size=8G \
    -device virtio-mem-pci,id=vmem2,memdev=mem2,node=3,requested-size=128M

[root@vm-0 ~]# dmesg | grep "ACPI: SRAT: Node"
[    0.009933] ACPI: SRAT: Node 0 PXM 0 [mem 0x00000000-0x0009ffff]
[    0.009939] ACPI: SRAT: Node 0 PXM 0 [mem 0x00100000-0xbfffffff]
[    0.009941] ACPI: SRAT: Node 0 PXM 0 [mem 0x100000000-0x23fffffff]
[    0.009942] ACPI: SRAT: Node 1 PXM 1 [mem 0x240000000-0x87fffffff] hotplug
[    0.009944] ACPI: SRAT: Node 2 PXM 2 [mem 0x240000000-0x87fffffff] hotplug
[    0.009946] ACPI: SRAT: Node 3 PXM 3 [mem 0x240000000-0x87fffffff] hotplug
[    0.009947] ACPI: SRAT: Node 4 PXM 4 [mem 0x240000000-0x87fffffff] hotplug
[root@vm-0 ~]# numactl --hardware
available: 4 nodes (0-3)
node 0 cpus: 0 1 2 3 4 5 6 7
node 0 size: 7950 MB
node 0 free: 7692 MB
node 1 cpus:
node 1 size: 128 MB
node 1 free: 123 MB
node 2 cpus:
node 2 size: 128 MB
node 2 free: 127 MB
node 3 cpus:
node 3 size: 128 MB
node 3 free: 127 MB
node distances:
node   0   1   2   3 
  0:  10  20  20  20 
  1:  20  10  20  20 
  2:  20  20  10  20 
  3:  20  20  20  10 



-- 
Thanks,

David / dhildenb