[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/7] hw/nvram: Update at24c EEPROM init function in NPCM7x
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2 5/7] hw/nvram: Update at24c EEPROM init function in NPCM7xx boards |
|
Date: |
Thu, 4 Nov 2021 20:50:12 +0000 |
On Wed, 3 Nov 2021 at 21:52, Hao Wu <wuhaotsh@google.com> wrote:
>
> Thanks for the comment. I'll upload a new version using IF_OTHER as discussed
> in that thread.
>
> I don't know if adding the assertion for type != IF_NONE is a good idea now
> so I didn't add that.
> If you think that's good I can add it as well.
We would have to fix the existing use of IF_NONE in the tree
before we could add an assert. (Awkward because it will
break commandlines for that existing use.)
-- PMM