qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/5] target/arm: Use tcg_constant_*


From: Richard Henderson
Subject: Re: [PATCH v3 0/5] target/arm: Use tcg_constant_*
Date: Mon, 1 Nov 2021 13:41:10 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/29/21 7:18 PM, Philippe Mathieu-Daudé wrote:
Missing review: patches #2 & #5 (new)

Introduce store_cpu_field_constant() helper to avoid using temporary
when the value is constant (and read-only).

Since v2:
- Simplify store_cpu_field_constant(), do not modify store_cpu_field()
- Added another use in gen_rev16()

Philippe Mathieu-Daudé (5):
   target/arm: Use tcg_constant_i32() in op_smlad()
   target/arm: Introduce store_cpu_field_constant() helper
   target/arm: Use the constant variant of store_cpu_field() when
     possible
   target/arm: Use tcg_constant_i64() in do_sat_addsub_64()
   target/arm: Use tcg_constant_i32() in gen_rev16()

  target/arm/translate-a32.h |  3 +++
  target/arm/translate-sve.c | 17 ++++++++---------
  target/arm/translate.c     | 27 ++++++++-------------------
  3 files changed, 19 insertions(+), 28 deletions(-)

Thanks, applied to target-arm.next.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]