[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Phptest-devel] Re:
|
From: |
dj resonance |
|
Subject: |
[Phptest-devel] Re: |
|
Date: |
Mon, 8 Jul 2002 08:00:38 -0700 (PDT) |
FYI, I've fixed the problems with cdatabase.inc.php.
I'm going to start on the question matrix today.
Brandon
--- John Lacey <address@hidden> wrote:
<HR>
<html>
<font size=3>Brandon,<br>
<br>
Thanks for the feedback, and as I've indicated, when I
get Eudora
figured<br>
out, I'll post to Phptest-devel. I have a
downlevel version of
Eudora, so<br>
I'm not optimistic -- I may have to upgrade, and I
don't care for MS
Outlook.<br>
<br>
If you want to give me cvs write access, go ahead.
I've downloaded
WinCVS<br>
and putty.exe, and I need to psyche WinCVS out some to
figure out how
to<br>
put stuff up correctly.<br>
<br>
I quickly scanned the doc page since you said you were
working on it and
<br>
found a few odds and ends -- not all are errors, e.g
the "define
variables"<br>
example being broken up into two lines and not
matching config.inc.php
exactly.<br>
Also, in your Jane scenario the word
"between" is misspelled
(betweeb), and<br>
I'd probably change the "teachers are lazy"
to "teachers
are busy" :)<br>
There might be a couple of other things that I missed
in my scan, since I
didn't<br>
proofread it. You know what you should do
-- find someone
(perhaps yourself)<br>
that has graphic talents and design a little phpTest
logo with Photoshop
or whatever<br>
so that people (like me) could put them on their
phpTest engine
"powered by"... etc<br>
ala
<a href="http://www.php.net/download-logos.php";
eudora="autourl">http://www.php.net/download-logos.php</a><br>
<br>
I noticed you've already fixed the email problem in
sql_error(). in
cdatabase.inc.php<br>
<br>
I just got a call from nacse (the non-profit) and they
said their Dell
server (1400SC) <br>
got delivered, so after 7/11 I'm on it. It's a
1.26GHz PIII, 1GB
RAM and 73GB SCSI<br>
with plenty of room to grow -- I'll have my work cut
out for me with all
the stuff<br>
I want to do for them. It'll be running redhat
7.2<br>
<br>
have a good 4th,<br>
John<br>
<br>
<br>
<br>
At 12:49 PM 7/3/2002 -0700, you wrote:<br>
>Hi John, <br>
><br>
>All the things you mentioned in cdatabase.inc.php
are<br>
>correct observations. I actually coded that
database<br>
>class when I first started learning php, and
have<br>
>gradually updated it as neccessary. But
obviously<br>
>I've missed a few things here and there. In this
case<br>
>I can just go and fix those problems myself, but
in<br>
>the future feel free to edit the code and resubmit
it<br>
>to me. This is where cvs can come in handy.<br>
><br>
>Talk to ya later,<br>
>Brandon<br>
><br>
>--- John Lacey <address@hidden>
wrote:<br>
>> Hi Brandon,<br>
>> <br>
>> I mentioned the other day that I had
recently<br>
>> started an informal log of<br>
>> notes I am making<br>
>> whenever I run across things that catch my
eye as<br>
>> I'm studying the code to<br>
>> 1.) learn how phpTest<br>
>> works, and 2.) implement a feature. I don't
now if<br>
>> you're interested in<br>
>> seeing the entries, so I <br>
>> pasted the few entries I've made so far
between the<br>
>> ****:<br>
>> <br>
>> *********************<br>
>> This is a log of "possible"
issues/problems/concerns<br>
>> encountered while<br>
>> studying phpTest -- started 6/30/02<br>
>> <br>
>> 6/30/02<br>
>> ***cdatabase.inc.php<br>
>> - from [p]connect() on an error, the link_id
is<br>
>> checked in sql_error() and<br>
>> to get to sql_error() link_id was null/0<br>
>> <br>
>> - connect() and pconnect() are coded
differently<br>
>> (error handling coding,<br>
>> etc) though they perform essentially the
same<br>
>> function<br>
>> <br>
>> - in sql_error() there's no check to see
if<br>
>> $admin_email contains an email<br>
>> address before displaying the msg to user and
it<br>
>> looks like <br>
>> $admin_email is not being set with the
ADMIN_EMAIL<br>
>> constant<br>
>> **********************<br>
>> <br>
>> Let me know if this would be of any use to
you, or<br>
>> how you'd like me to<br>
>> address things I<br>
>> come across down the road.<br>
>> <br>
>> thanks,<br>
>> John<br>
>> <br>
><br>
><br>
>__________________________________________________<br>
>Do You Yahoo!?<br>
>Sign up for SBC Yahoo! Dial - First Month Free<br>
><a href="http://sbc.yahoo.com/";
eudora="autourl">http://sbc.yahoo.com</a><br>
> </font>
<BR>
</html>
__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Phptest-devel] Re:,
dj resonance <=