librefm-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Librefm-commits] [1165] Throw out submitted tracks with rating set to '


From: Clint Adams
Subject: [Librefm-commits] [1165] Throw out submitted tracks with rating set to 'S'; right now they' re all from people using last. fm radio but submitting to us in violation of the protocol; this buys us a performance headache and little else.
Date: Sun, 03 May 2009 21:54:19 +0000

Revision: 1165
          http://svn.sv.gnu.org/viewvc/?view=rev&root=librefm&revision=1165
Author:   clint
Date:     2009-05-03 21:54:19 +0000 (Sun, 03 May 2009)
Log Message:
-----------
Throw out submitted tracks with rating set to 'S'; right now they're all from 
people using last.fm radio but submitting to us in violation of the protocol; 
this buys us a performance headache and little else.  In future if we care 
about skips, they should be saved to a different table.

Modified Paths:
--------------
    trunk/gnukebox/submissions/1.2/index.php

Modified: trunk/gnukebox/submissions/1.2/index.php
===================================================================
--- trunk/gnukebox/submissions/1.2/index.php    2009-05-03 21:34:22 UTC (rev 
1164)
+++ trunk/gnukebox/submissions/1.2/index.php    2009-05-03 21:54:19 UTC (rev 
1165)
@@ -117,7 +117,7 @@
 
        $exists = scrobbleExists($username, $artist, $track, $time);
 
-       if(!$exists) {
+       if((!$exists) && $rating<>'S') {
        // Scrobble!
        $rowvalues[$actualcount] = "("
                . $username . ", "





reply via email to

[Prev in Thread] Current Thread [Next in Thread]