librefm-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Librefm-commits] [1164] strtolower() is apparently useless for Unicode


From: Clint Adams
Subject: [Librefm-commits] [1164] strtolower() is apparently useless for Unicode
Date: Sun, 03 May 2009 21:34:22 +0000

Revision: 1164
          http://svn.sv.gnu.org/viewvc/?view=rev&root=librefm&revision=1164
Author:   clint
Date:     2009-05-03 21:34:22 +0000 (Sun, 03 May 2009)
Log Message:
-----------
strtolower() is apparently useless for Unicode

Modified Paths:
--------------
    trunk/gnukebox/musicbrainz.php
    trunk/nixtape/radio/xspf.php
    trunk/nixtape/track.php

Modified: trunk/gnukebox/musicbrainz.php
===================================================================
--- trunk/gnukebox/musicbrainz.php      2009-05-03 21:27:56 UTC (rev 1163)
+++ trunk/gnukebox/musicbrainz.php      2009-05-03 21:34:22 UTC (rev 1164)
@@ -88,7 +88,7 @@
 
                     global $mdb2;
 
-                       $sql = "select a.name as artist,l.name as album, t.name 
as track,t.gid as mbid from brainz.track t left join brainz.artist a on 
t.artist=a.id left join brainz.albumjoin j on j.track=t.id left join 
brainz.album l on l.id=j.album  where lower(t.name)=" . 
$mdb2->quote(strtolower($track)) . " and lower(a.name)=" . 
$mdb2->quote(strtolower($artist)) . " LIMIT 1;";
+                       $sql = "select a.name as artist,l.name as album, t.name 
as track,t.gid as mbid from brainz.track t left join brainz.artist a on 
t.artist=a.id left join brainz.albumjoin j on j.track=t.id left join 
brainz.album l on l.id=j.album  where lower(t.name)=" . 
$mdb2->quote(mb_strtolower($track, "UTF-8")) . " and lower(a.name)=" . 
$mdb2->quote(mb_strtolower($artist, "UTF-8")) . " LIMIT 1;";
                        
                        $resBrainz = $mdb2->query($sql);
 
@@ -103,4 +103,4 @@
 }
 
                ?>
-               </ul>
\ No newline at end of file
+               </ul>

Modified: trunk/nixtape/radio/xspf.php
===================================================================
--- trunk/nixtape/radio/xspf.php        2009-05-03 21:27:56 UTC (rev 1163)
+++ trunk/nixtape/radio/xspf.php        2009-05-03 21:34:22 UTC (rev 1164)
@@ -44,10 +44,10 @@
 
 if(ereg("l(ast|ibre)fm://globaltags/(.*)", $url, $regs)) {
        $tag = $regs[2];
-       $res = $mdb2->query("SELECT Track.name, Track.artist, Track.album FROM 
Track INNER JOIN Tags ON Track.name=Tags.track AND Track.artist=Tags.artist AND 
Track.album=Tags.album WHERE streamurl<>'' AND streamable=1 AND lower(tag) = " 
. $mdb2->quote(strtolower($tag), "text"));
+       $res = $mdb2->query("SELECT Track.name, Track.artist, Track.album FROM 
Track INNER JOIN Tags ON Track.name=Tags.track AND Track.artist=Tags.artist AND 
Track.album=Tags.album WHERE streamurl<>'' AND streamable=1 AND lower(tag) = " 
. $mdb2->quote(mb_strtolower($tag, "UTF-8"), "text"));
 } elseif(ereg("l(ast|ibre)fm://artist/(.*)/similarartists", $url, $regs)) {
        $artist = $regs[2];
-       $res = $mdb2->query("SELECT name, artist, album FROM Track WHERE 
streamurl<>'' AND streamable=1 AND lower(artist) = " . 
$mdb2->quote(strtolower($artist), "text"));
+       $res = $mdb2->query("SELECT name, artist, album FROM Track WHERE 
streamurl<>'' AND streamable=1 AND lower(artist) = " . 
$mdb2->quote(mb_strtolower($artist, "UTF-8"), "text"));
 } else {
        die("FAILED\n"); // this should return a blank dummy playlist instead
 }

Modified: trunk/nixtape/track.php
===================================================================
--- trunk/nixtape/track.php     2009-05-03 21:27:56 UTC (rev 1163)
+++ trunk/nixtape/track.php     2009-05-03 21:34:22 UTC (rev 1164)
@@ -38,7 +38,7 @@
         $smarty->assign('tagcloud', $aTagCloud);
 }
 
-$res = $mdb2->query("SELECT * FROM Track WHERE lower(artist) = " . 
$mdb2->quote(strtolower($track->artist_name),"text") . " AND lower(name) = " . 
$mdb2->quote(strtolower($track->name),"text"));
+$res = $mdb2->query("SELECT * FROM Track WHERE lower(artist) = " . 
$mdb2->quote(mb_strtolower($track->artist_name, "UTF-8"),"text") . " AND 
lower(name) = " . $mdb2->quote(mb_strtolower($track->name, "UTF-8"),"text"));
 
 $aOtheralbums = array();
 $i = 0;





reply via email to

[Prev in Thread] Current Thread [Next in Thread]