[Laptopkernel-devel] 2.4.21-rc8-laptop1 with Thinkpad t40 report

[Steve K]

Hey folks --

First of all, great idea maintaining this collection of patches, it sure made 
my life easier.  I ran the patch against 2.4.21 (as the changelog said there 
was no difference between 2.4.20-rc8 and 2.4.21) and it patched smoothly 
(except for the line in the Makefile that sets the version, but that was no 
big deal).  I did, however, have some trouble compiling it with gcc3.3 (aside 
from the 2 places where the stock kernel fails to compile with gcc3.3):

- mm/slab.c would not compile with software suspend support disabled:

slab.c: In function `kmem_cache_grow':
slab.c:1228: error: invalid lvalue in assignment
slab.c:1243: error: invalid lvalue in assignment
slab.c: In function `__kmem_cache_alloc':
slab.c:1421: error: invalid lvalue in assignment
slab.c:1438: error: invalid lvalue in assignment

Enabling software suspend support fixed this problem.

- drivers/char/agpgart_be.c had these errors when compiling:

agpgart_be.c: In function `x86_64_insert_memory':
agpgart_be.c:2819: warning: integer constant is too large for "long" type
agpgart_be.c:2820: warning: integer constant is too large for "long" type
agpgart_be.c: In function `amd_8151_configure':
agpgart_be.c:3002: warning: integer constant is too large for "long" type
agpgart_be.c: At top level:
agpgart_be.c:5108: error: `PCI_DEVICE_ID_VIA_8375' undeclared here (not in a 
function)
agpgart_be.c:5108: error: initializer element is not constant
agpgart_be.c:5108: error: (near initialization for 
`agp_bridge_info[56].device_id')
agpgart_be.c:5113: error: initializer element is not constant
agpgart_be.c:5113: error: (near initialization for `agp_bridge_info[56]')
agpgart_be.c:5119: error: initializer element is not constant
agpgart_be.c:5119: error: (near initialization for `agp_bridge_info[57]')
agpgart_be.c:5125: error: initializer element is not constant
agpgart_be.c:5125: error: (near initialization for `agp_bridge_info[58]')
agpgart_be.c:5126: error: `PCI_DEVICE_ID_VIA_P4M266' undeclared here (not in a 
function)
agpgart_be.c:5126: error: initializer element is not constant
agpgart_be.c:5126: error: (near initialization for 
`agp_bridge_info[59].device_id')
agpgart_be.c:5131: error: initializer element is not constant
agpgart_be.c:5131: error: (near initialization for `agp_bridge_info[59]')
agpgart_be.c:5137: error: initializer element is not constant
agpgart_be.c:5137: error: (near initialization for `agp_bridge_info[60]')
agpgart_be.c:5170: error: initializer element is not constant
agpgart_be.c:5170: error: (near initialization for `agp_bridge_info[61]')

I commented out the chunks of the struct that were causing the errors (since 
it refered to hardware I didn't have) and it compiled fine.

- drivers/net/pcnet32.c would not compile:

pcnet32.c:1660: error: `pcnet32_suspend' undeclared here (not in a function)
pcnet32.c:1660: error: initializer element is not constant
pcnet32.c:1660: error: (near initialization for `pcnet32_driver.suspend')
pcnet32.c:1663: error: `pcnet32_resume' undeclared here (not in a function)
pcnet32.c:1663: error: initializer element is not constant
pcnet32.c:1663: error: (near initialization for `pcnet32_driver.resume')

I just disabled this in the config as I don't need support for this anyway.

And finally, there seems to be a problem with the usbcore module.  When I try 
to modprobe it, I get:

/lib/modules/2.4.21/kernel/drivers/usb/usbcore.o: unresolved symbol 
refrigerator
/lib/modules/2.4.21/kernel/drivers/usb/usbcore.o: insmod 
/lib/modules/2.4.21/kernel/drivers/usb/usbcore.o failed
/lib/modules/2.4.21/kernel/drivers/usb/usbcore.o: insmod usbcore failed

Keep up the great work!

cheers,
-steve