guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 03/06: style: Add support for "newline forms".


From: Ludovic Courtès
Subject: Re: 03/06: style: Add support for "newline forms".
Date: Tue, 18 Jan 2022 15:56:05 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hi!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> guix-commits@gnu.org 写道:
>> +   ('base32 '(sha256 origin))
>
> I know this is your style, but I would *really* prefer this to be:
>
>> +   ('source '(package))
>
> instead.
>
> I know!  But wait!  I think that's defensible: for the same reason
> that we add a newline after arguments, these few extra columns 
> give an (IMO) surprising amount of breathing room down the road.

No strong opinion here, you may well be representing the majority, and
I’m fine with the change you propose.  :-)

There’s a couple of tests that will need to be adjusted but it should be
alright.

(Maybe a few months from now we’ll have additional switches, like
‘-x civodul’, ‘-x nckx’, who knows?  :-))

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]