Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.

[Denis 'GNUtoo' Carikli]

Sorry again for the delay, I had personal issues (that are now mostly
fixed) that needed urgent attention and that took all my time.

On Fri, 05 Apr 2024 17:03:21 -0500
Rob Browning <rlb@defaultvalue.org> wrote:
> Rob Browning <rlb@defaultvalue.org> writes:
> 
> > Apologies for the delay, and good point.  I should have used eqv?
> > rather than char=?, i.e.
> >
> >              (let ((ch (read-char port)))
> >                (if (eqv? ch #\:)
> >                    (set! ch (read-char port))
> >                (if (eof-object? ch)
> >                    (time-error 'string->date
> > 'bad-date-template-string (list "Invalid time zone number" ch)))
> >                (set! ...))  
> 
> Just checking back -- does that adjustment seem plausible to you? 
Yes, that makes the code much better and since when ch is eof, '(eqv? ch
#\:)' returns #f, so it should work.

> If so, I may adjust your patch and proceed with it.
Thanks a lot.

Denis.

pgpmzg3IRAh1N.pgp
Description: OpenPGP digital signature