guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.


From: Rob Browning
Subject: Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.
Date: Tue, 19 Mar 2024 19:21:19 -0500

Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> writes:

> Would something like that be OK instead?:

Not sure I understand the question.  Were you asking if that'd be OK
elsewhere in the function too?

> However here (char=? ch #\:) can fail if ch is an eof-object.

Apologies for the delay, and good point.  I should have used eqv? rather
than char=?, i.e.

             (let ((ch (read-char port)))
               (when (eqv? ch #\:)
                   (set! ch (read-char port))
               (if (eof-object? ch)
                   (time-error 'string->date 'bad-date-template-string
                               (list "Invalid time zone number" ch)))
               (set! ...))

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4



reply via email to

[Prev in Thread] Current Thread [Next in Thread]