guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Guile-Lib PATCH v4 0/7] Make log-msg accept source properties for displ


From: Maxim Cournoyer
Subject: [Guile-Lib PATCH v4 0/7] Make log-msg accept source properties for displaying source location
Date: Sun, 25 Feb 2024 09:19:06 -0500

The main change of this series is adding the ability to pass source
properties (such as can be obtained via syntax-source in macros, for
example [0]) to the `log-msg' call, and have the default log formatter
use it to display the source location of the corresponding call.  The
procedure name where the log-msg call was made is also resolved and
made available to the log formatter.

It also fixes a few minor issues spotted while working with the
source, and calls `flush-log' at the end of `accept-log' to avoid
long delays caused by the default block buffering when the log traffic
is low.

[0]  https://issues.guix.gnu.org/68946

Changes in v4:
 - Reword commit messages per David's preference
 - log-helper's source-properties argument is now a keyword argument
 - original accept-log method restored (on top of new one)

Changes in v3:
 - Use (ice-9 format) for the default-log-formatter
 - Use a keyword argument for the source-properties
 - Add proc-name argument to default-log-formatter

Changes in v2:
 - Relax log-msg typing on source-properties, as it can also be #f

Maxim Cournoyer (7):
  configure.ac: Fix typo in message.
  Use /bin/sh in update-api script shebang.
  tests: guile-library.api: Re-generate.
  logging: Allow passing source properties to `log-msg'.
  logging: Adjust default log-formatter output.
  logging: Make procedure name available to the log formatter.
  logging: Call flush-log at the end of accept-log.

 configure.ac                  |   2 +-
 src/logging/logger.scm        | 109 ++++++++++-----
 unit-tests/guile-library.api  | 247 ++--------------------------------
 unit-tests/logging.logger.scm |  18 ++-
 unit-tests/update-api         |   2 +-
 5 files changed, 103 insertions(+), 275 deletions(-)


base-commit: 8d0196230f80afcf4da33917fe8ae390a1560931
-- 
2.41.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]