guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Added srfi-214: flexvectors


From: Vijay Marupudi
Subject: Re: [PATCH] Added srfi-214: flexvectors
Date: Thu, 20 Jan 2022 10:34:37 -0500

> Guile's README cannot override the law, so the expat license text
> would need to remain.  I think test-suite/README is primarily
> concerned license compatibility and consistency, so I guess
> for code from external sources, the ‘let GPL be the license’
> requirement can be relaxed somewhat.
>
> For example, see tests/srfi-27.test and tests/srfi-41.test -- they
> appear to be Expat.

Thanks for providing the examples, I have updated the tests to follow
the requirement. The latest version of the patch is attached. Licenses
are tricky things!

> Something I forgot to mention: documentation!  Would you be up
> to documenting flexvectors in Guile (in ‘6.6 Datatypes’ I presume,
> after ‘vlists’ maybe, with a cross-reference from
> ‘7.5 SRFI Support Modules’)?

My latest patch now has documentation, mostly derived from the SRFI-214
documentation. Who would have figured that conversion to texinfo would be the
most time consuming part of this patch?

I would like advice on how to attribute the documentation to Adam Nelson.

> As I understand it, a maintainer will inform you on what you
> need to sign, etc -- it's a process initiated by the maintainer,
> not the contributor.

Sounds good.

Attached is the latest version of the patch.

~ Vijay

Attachment: 0001-Added-srfi-214-flexvectors.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]