[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Initialize local relocator subchunk struct to all zeros
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] Initialize local relocator subchunk struct to all zeros |
|
Date: |
Tue, 19 Jul 2022 14:01:02 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, Jul 15, 2022 at 05:21:21PM -0400, Alec Brown wrote:
> On Thu, Jul 14, 2022 at 03:38:04PM +0100, Darren Kenny wrote:
> > Hi Ross,
> >
> > This looks good to me.
> >
> > On Thursday, 2022-07-14 at 09:41:28 -04, Ross Philipson wrote:
> > > The way the code is written the tofree variable would never be
> > > passed to the free_subchunk() function uninitialized. Coverity
> > > cannot determine this and flags the situation as "Using uninitialized
> > > value...". The fix is just to initialize the local struct.
> > >
> > > Fixes: CID 314016
> > >
> > > Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
> >
> > Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
>
> I ran this through a private Coverity scan which marked the bug as eliminated
> and didn't have any issues running it on a VM.
>
> Tested-by: Alec Brown <alec.r.brown@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel