Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions

[Mathieu Desnoyers]

----- On May 27, 2022, at 10:56 AM, Robbie Harwood rharwood@redhat.com wrote:

> Michael Chang via Grub-devel <grub-devel@gnu.org> writes:
> 
>> On Thu, May 26, 2022 at 05:07:11PM -0400, Robbie Harwood wrote:
>>> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes:
>>> 
>>>> There are no users left of version_find_latest(), version_test_gt(),
>>>> and version_test_numeric(). Remove those unused helper
>>>> functions. Using those helper functions is what caused the quadratic
>>>> sorting performance issues in the first place, so removing them is a
>>>> net win.
>>>>
>>>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>>> 
>>> Reviewed-by: Robbie Harwood <rharwood@redhat.com>
>>
>> Hm. This seems to contradict your proposed patch to use distro specific
>> sort by hooking into those functions got removed here.
>>
>>  mkconfig: use distro sorts when available
>>  https://www.mail-archive.com/grub-devel@gnu.org/msg33357.html
>>
>> I'd like to know more your comments about this as those hooks might
>> still be needed or where to keep distribution's sort ?
> 
> The series does, yes - both can't be applied as-is.  I'm fine to rebase
> mine, but haven't done it yet.  I don't mind adding them back if I need
> to.

Please be mindful not to add back the quadratic sorting algorithm as you
do that.

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com