Re: [PATCH 2/2] docs: Add documentation for the efitextmode command

[Paul Menzel]

Dear Glenn,


Thank you for the patch. Two small nits.

Am 12.05.22 um 05:07 schrieb Glenn Washburn:
> Signed-off-by: Glenn Washburn <development@efficientek.com>

*Add documentation for …* could be abbreviated to *Document …* in the 
git commit message summary.

> ---
>   docs/grub.texi | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
>
> diff --git a/docs/grub.texi b/docs/grub.texi
> index 3b5522b0a..50ef28edd 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4202,6 +4202,7 @@ you forget a command, you can run the command 
> @command{help}
>  * distrust::                    Remove a pubkey from trusted keys
>  * drivemap::                    Map a drive to another
>  * echo::                        Display a line of text
> +* efitextmode::                 Set/Get text output mode resolution
>  * eval::                        Evaluate agruments as GRUB commands
>  * export::                      Export an environment variable
>  * false::                       Do nothing, unsuccessfully
> @@ -4638,6 +4639,28 @@ character will print that character.
>   @end deffn
>   
>   
> +@node efitextmode
> +@subsection efitextmode
> +
> +@deffn Command efitextmode [min | max | mode_num]
> +When used with no arguments displays all available text output modes. The
> +set mode determines the columns and rows of the text display when in
> +text mode. An asterisk, @samp{*}, will be at the end of the line of the
> +currently set mode.
> +
> +Otherwise the command only takes a single parameter, which can be
> +@samp{min}, @samp{max}, or a mode number given by the listing when run
> +with no arguments. These arguments set the mode to the minimum, maximum,
> +and particular mode respectively.
> +
> +By default GRUB will start in whatever mode the EFI firmware defaults to.
> +There are firmwares known to setup the default mode such that output

The verb *set up* is spelled with a space.

> +behaves strangely. Setting the mode can fix this.

Should your device be mentioned in the documentation, and one of the 
strangeness be described?

> +
> +Note: This command is only available on EFI platforms.
> +@end deffn
> +
> +
>   @node eval
>   @subsection eval


Kind regards,

Paul