Re: [PATCH v2] efi: Set text-mode console resolution to maximum supported

[Gerd Hoffmann]

  Hi,

> v2: Fix to query each mode instead of just the current mode

Oh, right, that is another one ...

> +  /* Set text-mode resolution to maximum supported */
> +  o = grub_efi_system_table->con_out;
> +  for (i=0, columns_max=0, rows_max=0, mode_max=0; i < o->mode->max_mode; 
> i++)
> +    if (GRUB_EFI_SUCCESS == efi_call_4 (o->query_mode, o, i,
> +                                       &columns, &rows)
> +       && (columns_max * rows_max) < (columns * rows))

... but I meant that this condition always evaluates to true because you
never update columns_max and rows_max ...

> +      mode_max = i;

... so mode_max is o->mode->max_mode - 1 at this point no matter what.

take care,
  Gerd