Re: [PATCH v8 0/7] Cryptodisk detached headers and key files

[Daniel Kiper]

On Sat, Jan 01, 2022 at 09:52:53PM -0600, Glenn Washburn wrote:
> This patch series is an updated version of the v7 sent by Denis Carikli with
> modifications to reflect changes in argument passing to crypto backends. The
> previous patch #6 titled "Add support for LUKS1 key files" has been removed
> as its not needed anymore. Patches #6 and #7 are new, for updating the
> cryptomount help string and adding support for detached headers in the LUKS2
> crypto backend, respectively.
>
> I modified the commit tags from v7 as seemed appropriate to me, but they may
> not be desirable as-is.
>
> Glenn
>
> Denis 'GNUtoo' Carikli (2):
>   cryptodisk: luks: unify grub_cryptodisk_dev function names
>   cryptodisk: geli: unify grub_cryptodisk_dev function names
>
> Glenn Washburn (3):
>   cryptodisk: enable the backends to implement detached headers
>   cryptodisk: Improve cryptomount short help string
>   luks2: Add detached header support
>
> John Lane (2):
>   cryptodisk: add support for LUKS1 detached headers
>   cryptodisk: enable the backends to implement key files

I think most of the patches if not all require shorter or longer
explanation why they are needed, what they are doing, etc. One liner
subject is not enough for this patch series. Additionally, there are
missing additions to the documentation. Please correct that and I will
continue reviewing the series.

Daniel