[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/15] ieee1275: drop len -= 1 quirk in heap_init
From: |
Daniel Axtens |
Subject: |
[PATCH v2 12/15] ieee1275: drop len -= 1 quirk in heap_init |
Date: |
Mon, 28 Mar 2022 17:22:37 +1100 |
This was apparently 'required by some firmware': commit dc9468500919
("2007-02-12 Hollis Blanchard <hollis@penguinppc.org>").
It's not clear what firmware that was, and what platform from 14 years ago
which exhibited the bug then is still both in use and buggy now.
It doesn't cause issues on qemu (mac99 or pseries) or under PFW for Power8.
I don't have access to old Mac hardware, but if anyone feels especially
strongly we can put it under some feature flag. I really want to disable
it under pseries because it will mess with region merging.
Signed-off-by: Daniel Axtens <dja@axtens.net>
---
grub-core/kern/ieee1275/init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c
index d44efd99cfca..eeb11dd40ded 100644
--- a/grub-core/kern/ieee1275/init.c
+++ b/grub-core/kern/ieee1275/init.c
@@ -166,7 +166,6 @@ heap_init (grub_uint64_t addr, grub_uint64_t len,
grub_memory_type_t type,
addr = 0x180000;
}
}
- len -= 1; /* Required for some firmware. */
/* Never exceed HEAP_MAX_SIZE */
if (*total + len > HEAP_MAX_SIZE)
--
2.32.0
- [PATCH v2 03/15] mm: when adding a region, merge with region after as well as before, (continued)
- [PATCH v2 03/15] mm: when adding a region, merge with region after as well as before, Daniel Axtens, 2022/03/28
- [PATCH v2 01/15] grub-shell: only pass SeaBIOS fw_opt in for x86 BIOS platforms, Daniel Axtens, 2022/03/28
- [PATCH v2 04/15] mm: debug support for region operations, Daniel Axtens, 2022/03/28
- [PATCH v2 05/15] mm: Drop unused unloading of modules on OOM, Daniel Axtens, 2022/03/28
- [PATCH v2 06/15] mm: Allow dynamically requesting additional memory regions, Daniel Axtens, 2022/03/28
- [PATCH v2 07/15] efi: mm: Always request a fixed number of pages on init, Daniel Axtens, 2022/03/28
- [PATCH v2 08/15] efi: mm: Extract function to add memory regions, Daniel Axtens, 2022/03/28
- [PATCH v2 10/15] efi: mm: Implement runtime addition of pages, Daniel Axtens, 2022/03/28
- [PATCH v2 09/15] efi: mm: Pass up errors from `add_memory_regions ()`, Daniel Axtens, 2022/03/28
- [PATCH v2 11/15] ieee1275: request memory with ibm, client-architecture-support, Daniel Axtens, 2022/03/28
- [PATCH v2 12/15] ieee1275: drop len -= 1 quirk in heap_init,
Daniel Axtens <=
- [PATCH v2 13/15] ieee1275: support runtime memory claiming, Daniel Axtens, 2022/03/28
- [PATCH v2 14/15] [RFC] Add memtool module with memory allocation stress-test, Daniel Axtens, 2022/03/28
- [PATCH v2 15/15] ibmvtpm: Add support for trusted boot using a vTPM 2.0, Daniel Axtens, 2022/03/28