grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] configure: Allow HOST_CC to override CC


From: Daniel Kiper
Subject: Re: [PATCH 1/5] configure: Allow HOST_CC to override CC
Date: Thu, 24 Mar 2022 14:37:21 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Mar 18, 2022 at 01:41:35AM -0500, Glenn Washburn wrote:
> According to the INSTALL, "The HOST_* variables override not prefixed
> variables". This change makes it so, instead of previous behavior, which
> was to ignore the HOST_CC environment variable.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  configure.ac | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 3b8be28d9d..387ac22b86 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -78,6 +78,11 @@ grub_TRANSFORM([grub-sparc64-setup])
>  grub_TRANSFORM([grub-render-label])
>  grub_TRANSFORM([grub-file])
>
> +# Allow HOST_CC to override CC
> +if test "x$HOST_CC" != x; then
> +  CC=$HOST_CC
> +fi
> +

I am OK with this change but what about the other HOST_* variables
mentioned in the INSTALL file, e.g. HOST_CFLAGS? It seems to me we have
the same/similar problems with them. Could you fix these issues too?

And it looks the TARGET_* variables also do not work as mentioned in the
INSTALL file. So, the INSTALL file should be updated and/or configure.ac
fixed.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]