grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] EFI/menu: Do not print messages when autobooting with TI


From: Daniel Kiper
Subject: Re: [PATCH 0/2] EFI/menu: Do not print messages when autobooting with TIMEOUT_STYLE_HIDDEN
Date: Tue, 22 Mar 2022 14:46:36 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Mar 04, 2022 at 11:36:30AM +0100, Hans de Goede wrote:
> Hi Daniel,
>
> On 1/28/22 11:30, Hans de Goede wrote:
> > Hi All,
> >
> > This series in essence is a renewed attempt to get grub to really
> > be truly hidden when autobooting with TIMEOUT_STYLE_HIDDEN.
> >
> > This is something which multiple big Linux distributions want,
> > this is a minimized version of my previous attempt from March 2018:
> > https://lists.gnu.org/archive/html/grub-devel/2018-03/msg00126.html
> > With some discussion about this patch in April 2018:
> > https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00009.html
> >
> > The first patch silences the notify_booting() callback from
> > grub-core/normal/menu.c based on the timeout_style (1), as
> > suggested in the original discussion.
> >
> > After that there is just one message left, from grub-core/kern/main.c
> > which is printed before the config file loads. When timeout_style
> > is not set to hidden this will only show very briefly to then be
> > replaced by the menu / countdown; and with timeout_style=hidden
> > we actually want it to behave the same as any other grub messages
> > and have it hidden. The second patch makes this happen by just
> > disabling the logging of the message for EFI builds.
> >
> > This also fixes the message briefly flashing by (in an ugly manner
> > because of the "flash" part) when timeout_style!=hidden.
> >
> > Regards,
> >
> > Hans
> >
> >
> > 1) It is only silenced when autobooting with TIMEOUT_STYLE_HIDDEN
>
> What is the status of this series? It has been well over a month and both
> patches have received a Reviewed-by and no other comments:
>
> Reviewed-by: Robbie Harwood <rharwood@redhat.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]