[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable
From: |
Alec Brown |
Subject: |
[PATCH v2 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable |
Date: |
Mon, 21 Mar 2022 02:28:58 -0400 |
In the function grub_net_arp_receive(), grub_net_network_level_address_t
sender_addr and target_addr are being called but aren't being initialized. In
both of these structs, each member is being set to a value except for
grub_dns_option_t option. This results in this member being filled with junk
data from the stack. To prevent this, we can set the option member in both
structs to 0.
Fixes: CID 375030
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
grub-core/net/arp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/grub-core/net/arp.c b/grub-core/net/arp.c
index 54306e3b1..1d367436c 100644
--- a/grub-core/net/arp.c
+++ b/grub-core/net/arp.c
@@ -128,6 +128,8 @@ grub_net_arp_receive (struct grub_net_buff *nb, struct
grub_net_card *card,
target_addr.type = GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV4;
sender_addr.ipv4 = arp_packet->sender_ip;
target_addr.ipv4 = arp_packet->recv_ip;
+ sender_addr.option = 0;
+ target_addr.option = 0;
if (arp_packet->sender_ip == pending_req)
have_pending = 1;
--
2.27.0
- [PATCH v2 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Alec Brown, 2022/03/21
- [PATCH v2 4/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable,
Alec Brown <=
- [PATCH v2 6/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 5/7] grub-core/net/net.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- Re: [PATCH v2 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Darren Kenny, 2022/03/21