[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] grub-mkimage: Only check aarch64 relocations when built
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 1/2] grub-mkimage: Only check aarch64 relocations when built for aarch64 |
|
Date: |
Wed, 16 Mar 2022 19:17:13 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Mar 16, 2022 at 05:25:04PM +0000, Darren Kenny wrote:
> Coverity flagged the switch checks for R_AARCH64_* as being logically
> dead code, since it could never happen on x86 due to the masking of the
> values earlier in the code.
>
> A check for building on __ARM_ARCH (which gcc and clang define) and for
> MKIMAGE_ELF64 (which GRUB defines) has been added to avoid this dead
> code being built in.
>
> Fixes: CID 158599
>
> Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel