[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable
From: |
Alec Brown |
Subject: |
[PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable |
Date: |
Tue, 15 Mar 2022 16:24:07 -0400 |
In the function grub_net_ipv6_get_link_local(), grub_net_network_level_address_t
addr is called but isn't being initialized. To prevent contents of this
structure from being filled with junk data from the stack, we can initialize it
to 0 by setting addr to {};
Fixes: CID 375033
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
grub-core/net/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 4d3eb5c1a..4e93365a7 100644
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -287,7 +287,7 @@ grub_net_ipv6_get_link_local (struct grub_net_card *card,
struct grub_net_network_level_interface *inf;
char *name;
char *ptr;
- grub_net_network_level_address_t addr;
+ grub_net_network_level_address_t addr = {};
addr.type = GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV6;
addr.ipv6[0] = grub_cpu_to_be64_compile_time (0xfe80ULL << 48);
--
2.27.0
- [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Alec Brown, 2022/03/15
- [PATCH 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 4/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable,
Alec Brown <=
- [PATCH 6/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- Re: [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Darren Kenny, 2022/03/15