[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variab
From: |
Alec Brown |
Subject: |
[PATCH 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable |
Date: |
Tue, 15 Mar 2022 16:24:03 -0400 |
In the function grub_netbsd_setup_video(), struct grub_netbsd_btinfo_framebuf
params is called but isn't being initialized. To prevent contents of this
structure from being filled with junk data from the stack, we can initialize it
to 0
by setting params to {}.
Fixes: CID 375026
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
grub-core/loader/i386/bsd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/loader/i386/bsd.c b/grub-core/loader/i386/bsd.c
index 5f3290ce1..b99344556 100644
--- a/grub-core/loader/i386/bsd.c
+++ b/grub-core/loader/i386/bsd.c
@@ -929,7 +929,7 @@ grub_netbsd_setup_video (void)
struct grub_video_mode_info mode_info;
void *framebuffer;
const char *modevar;
- struct grub_netbsd_btinfo_framebuf params;
+ struct grub_netbsd_btinfo_framebuf params = {};
grub_err_t err;
grub_video_driver_id_t driv_id;
--
2.27.0
- [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Alec Brown, 2022/03/15
- [PATCH 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable,
Alec Brown <=
- [PATCH 4/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 6/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- Re: [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Darren Kenny, 2022/03/15