grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] po: Un-transliterate the %zu format code


From: Glenn Washburn
Subject: Re: [PATCH] po: Un-transliterate the %zu format code
Date: Wed, 9 Mar 2022 18:10:12 -0600

On Wed, 9 Mar 2022 17:10:01 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:

> On Mon, Mar 07, 2022 at 12:15:36PM -0600, Glenn Washburn wrote:
> > Commit 45bffae13 uses the %zu format specifier which has not been used in
> 
> If you mention a commit please use the following format:
>   commit 45bffae13 (util/resolve: Bail with error if moddep.lst file line is 
> too long)

Ok, I'm not clear if this is just for the future, or you want me to
resend this patch. I have no problem resending.

Glenn

> 
> > any translated strings yet. So the sed scripts used for tranliterating
> > certain languages need to be updated otherwise creation of the message
> > indexes will fail on an unknown format code. This is essentially the same
> > issue fixed for the %m format code in commit 2e246b6f.
> 
> Ditto.
> 
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  po/arabic.sed   | 3 ++-
> >  po/cyrillic.sed | 3 ++-
> >  po/greek.sed    | 3 ++-
> >  po/hebrew.sed   | 3 ++-
> >  4 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/po/arabic.sed b/po/arabic.sed
> > index 21dc8b6db2..3fbee72480 100644
> > --- a/po/arabic.sed
> > +++ b/po/arabic.sed
> > @@ -74,9 +74,10 @@ s,%\([0-9]*\)للد,%\1lld,g
> >
> >  s,%\([0-9\.\*]*\)س,%\1s,g
> >  s,%\([0-9\.\*]*\)م,%\1m,g
> > -s,%\([0-9]*\)لو,%\1lu,g
> >  s,%\([0-9]*\)و,%\1u,g
> > +s,%\([0-9]*\)لو,%\1lu,g
> 
> I am OK with this move but please mention it in the commit message.
> 
> >  s,%\([0-9]*\)للو,%\1llu,g
> > +s,%\([0-9]*\)زو,%\1zu,g
> >  s,%\([0-9]*\)كس,%\1x,g
> >  s,%\([0-9]*\)لكس,%\1lx,g
> >  s,%\([0-9]*\)للكس,%\1llx,g
> > diff --git a/po/cyrillic.sed b/po/cyrillic.sed
> > index 2e3e6655d6..472f095295 100644
> > --- a/po/cyrillic.sed
> > +++ b/po/cyrillic.sed
> > @@ -97,9 +97,10 @@ s,%\([0-9]*\)ллд,%\1lld,g
> >
> >  s,%\([0-9\.\*]*\)с,%\1s,g
> >  s,%\([0-9\.\*]*\)м,%\1m,g
> > -s,%\([0-9]*\)лу,%\1lu,g
> >  s,%\([0-9]*\)у,%\1u,g
> > +s,%\([0-9]*\)лу,%\1lu,g
> 
> Ditto and below...
> 
> Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]