[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] mm: Export grub_mm_dump and grub_mm_dump_free
From: |
Glenn Washburn |
Subject: |
Re: [PATCH 2/3] mm: Export grub_mm_dump and grub_mm_dump_free |
Date: |
Fri, 25 Feb 2022 15:04:57 -0600 |
On Tue, 22 Feb 2022 19:03:39 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:
> On Tue, Feb 15, 2022 at 12:36:42PM -0600, Glenn Washburn wrote:
> > These functions may be useful within modules as well. Export them so that
> > modules can use them.
>
> Though there are no users for these functions today. So, I am not
> convinced we should export them.
How do you know there are no users for these functions today? As I see
it, the point of these functions is only for doing memory debugging.
They should not be enabled in general use. So no modules should ever
use them unconditionally. Also, here they are only export _if_
configure was passed --mm-debug or MM_DEBUG is defined, which is never
don't by default and likey only done when someone would be more likely
to use these functions. I'm not quite following what the concern is.
Glenn