Re: [PATCH] Retire ChangeLog-2015

[Javier Martinez Canillas]

Hello Daniel,

On 2/25/22 13:03, Daniel Kiper wrote:
> On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote:
>> Hello Peter,
>>
>> Thanks a lot for your patch.
>>
>> On 2/24/22 22:55, Peter Jones wrote:
>>> ChangeLog-2015 has been untouched for over 7 years now, and any
>>> information in it is purely for historical purposes.  At the same time,
>>> grepping for code winds up matching this file quite a bit, almost never
>>> accomplishing anything other than cluttering up your grep results.  We
>>> don't need this in the main repo, and "git show" will find it if you're
>>> looking at the old history of commits on some file.
>>>
>>> This patch deletes it.
>>
>> Yes, let's *please* get rid of this ChangeLog. It doesn't add any
>> value AFAICT and makes doing greps over the codebase much harder.
>>
>>> Signed-off-by: Peter Jones <pjones@redhat.com>
>>> Reviewed-by: Daniel Axtens <dja@axtens.net>
>>> Reviewed-by: Robbie Harwood <rharwood@redhat.com>
>>
>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> 
> I agree with above but it requires more than just ChangeLog-2015 file
> removal. The file is referenced at least in Makefile.am. Additionally,

Can we do these as follow-ups ? Looking at my bash history most (if not
all) of the grep commands I did on the GRUB codebase are like following:

  $ git grep grub_unixtime2datetime | grep -v ChangeLog

> may we consider addition of a script which generates ChangeLog file
> from the git log? I think we could steal it from here [1][2]. And if we
> do that I think we could drop NEWS file too (it is referenced in README;
> so, it should be dropped from there too).
>

Yes, these sounds good improvements too but out of scope for this patch in
my opinion.
 -- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat