grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/8] LoongArch: Add setjmp implementation


From: WANG Xuerui
Subject: Re: [PATCH v2 3/8] LoongArch: Add setjmp implementation
Date: Thu, 24 Feb 2022 00:13:08 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0a1

On 2/23/22 21:46, Xiaotian Wu wrote:
Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn>
Signed-off-by: Zhou Yang <zhouyang@loongson.cn>
Signed-off-by: Sun Haiyong <sunhaiyong@loongson.cn>
---
  grub-core/lib/loongarch64/setjmp.S | 68 ++++++++++++++++++++++++++++++
  grub-core/lib/setjmp.S             |  2 +
  include/grub/loongarch64/setjmp.h  | 27 ++++++++++++
  3 files changed, 97 insertions(+)
  create mode 100644 grub-core/lib/loongarch64/setjmp.S
  create mode 100644 include/grub/loongarch64/setjmp.h

diff --git a/grub-core/lib/loongarch64/setjmp.S 
b/grub-core/lib/loongarch64/setjmp.S
new file mode 100644
index 000000000..c11fe63ea
--- /dev/null
+++ b/grub-core/lib/loongarch64/setjmp.S
@@ -0,0 +1,68 @@
+/*
+ *  GRUB  --  GRand Unified Bootloader
+ *  Copyright (C) 2022 Free Software Foundation, Inc.
+ *
+ *  GRUB is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  GRUB is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with GRUB.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <grub/dl.h>
+
+       .file   "setjmp.S"
+
+GRUB_MOD_LICENSE "GPLv3+"
+
+       .text
+
+/*
+ * int grub_setjmp (jmp_buf env)
+ */
+FUNCTION(grub_setjmp)
+       st.d $s0, $a0, 0x0
+       st.d $s1, $a0, 0x8
+       st.d $s2, $a0, 0x10
+       st.d $s3, $a0, 0x18
+       st.d $s4, $a0, 0x20
+       st.d $s5, $a0, 0x28
+       st.d $s6, $a0, 0x30
+       st.d $s7, $a0, 0x38
+       st.d $s8, $a0, 0x40
+       st.d $fp, $a0, 0x48
+       st.d $sp, $a0, 0x50
+       st.d $ra, $a0, 0x58
+
+       move $a0, $zero
+       jr   $ra
+
+/*
+ * void grub_longjmp (jmp_buf env, int val)
+ */
+FUNCTION(grub_longjmp)
+       ld.d $s0, $a0, 0x0
+       ld.d $s1, $a0, 0x8
+       ld.d $s2, $a0, 0x10
+       ld.d $s3, $a0, 0x18
+       ld.d $s4, $a0, 0x20
+       ld.d $s5, $a0, 0x28
+       ld.d $s6, $a0, 0x30
+       ld.d $s7, $a0, 0x38
+       ld.d $s8, $a0, 0x40
+       ld.d $fp, $a0, 0x48
+       ld.d $sp, $a0, 0x50
+       ld.d $ra, $a0, 0x58
+
+       li.w $a0, 1
+       beqz $a1, .L0
+       move $a0, $a1
+.L0:
While this label name could just be "1" and the beqz reference changed to "1f", I don't have really strong opinion, besides perhaps adding a comment explaining the double return logic would be useful (refer to the riscv version's comment).
+       jr   $ra
diff --git a/grub-core/lib/setjmp.S b/grub-core/lib/setjmp.S
index 9c8721088..cba1d546d 100644
--- a/grub-core/lib/setjmp.S
+++ b/grub-core/lib/setjmp.S
@@ -19,6 +19,8 @@
  #include "./arm/setjmp.S"
  #elif defined(__aarch64__)
  #include "./arm64/setjmp.S"
+#elif defined(__loongarch64)
+#include "./loongarch64/setjmp.S"
  #elif defined(__riscv)
  #include "./riscv/setjmp.S"
  #else
diff --git a/include/grub/loongarch64/setjmp.h 
b/include/grub/loongarch64/setjmp.h
new file mode 100644
index 000000000..cb3e17763
--- /dev/null
+++ b/include/grub/loongarch64/setjmp.h
@@ -0,0 +1,27 @@
+/*
+ *  GRUB  --  GRand Unified Bootloader
+ *  Copyright (C) 2022 Free Software Foundation, Inc.
+ *
+ *  GRUB is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  GRUB is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with GRUB.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef GRUB_SETJMP_CPU_HEADER
+#define GRUB_SETJMP_CPU_HEADER 1
+
+typedef grub_uint64_t grub_jmp_buf[12];
+
+int grub_setjmp (grub_jmp_buf env) RETURNS_TWICE;
+void grub_longjmp (grub_jmp_buf env, int val) __attribute__ ((noreturn));
+
+#endif /* ! GRUB_SETJMP_CPU_HEADER */

With the nit addressed:

Reviewed-by: WANG Xuerui <git@xen0n.name>

Attachment: OpenPGP_0xC01F7214BC931414.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]