Re: [PATCH v5 0/4] Update gnulib and drop some patches

[Daniel Kiper]

On Tue, Feb 22, 2022 at 11:44:37AM -0500, Robbie Harwood wrote:
> Daniel Kiper <dkiper@net-space.pl> writes:
>
> > On Wed, Feb 16, 2022 at 04:41:38PM -0500, Robbie Harwood wrote:
> >> Changes in this version:
> >>
> >> - Include most _GL_* defines from gnulib.  Hopefully we do not need all 
> >> their
> >>   prereq logic as well, but I don't know what the compilers we support 
> >> are, so
> >>   please correct that if needed.
> >>
> >> - Avoid creating empty #defines.
> >>
> >> - Fix issues with building gnulib's allocation modules observed by Glenn.  
> >> The
> >>   tree now builds warning-free with default cflags for me.
> >
> > ./configure --target=arm-linux-gnueabihf --with-platform=coreboot 
> > --enable-grub-mkfont ...
> >
> > make ...
> >
> > ... and you will get this... :-(
> >
> >   In file included from lib/gnulib/malloc/dynarray_resize.c:25:0:
> >   lib/gnulib/malloc/dynarray_resize.c: In function ‘gl_dynarray_resize’:
> >   ../grub-core/lib/gnulib/intprops.h:592:8: error: comparison of unsigned 
> > expression < 0 is always false [-Werror=type-limits]
> >      ((b) < 0 \
> >           ^
> >   ../grub-core/lib/gnulib/intprops.h:536:4: note: in expansion of macro 
> > ‘_GL_INT_MULTIPLY_RANGE_OVERFLOW’
> >      (overflow (a, b, tmin, tmax) \
> >       ^~~~~~~~
> >   ../grub-core/lib/gnulib/intprops.h:479:8: note: in expansion of macro 
> > ‘_GL_INT_OP_CALC’
> >         ? _GL_INT_OP_CALC (a, b, r, op, overflow, unsigned int, st, smin, 
> > smax) \
> >           ^~~~~~~~~~~~~~~
> >   ../grub-core/lib/gnulib/intprops.h:494:7: note: in expansion of macro 
> > ‘_GL_INT_OP_WRAPV_SMALLISH’
> >        ? _GL_INT_OP_WRAPV_SMALLISH (a, b, r, op, overflow, \
> >          ^~~~~~~~~~~~~~~~~~~~~~~~~
> >   ../grub-core/lib/gnulib/intprops.h:418:4: note: in expansion of macro 
> > ‘_GL_INT_OP_WRAPV’
> >       _GL_INT_OP_WRAPV (a, b, r, *, _GL_INT_MULTIPLY_RANGE_OVERFLOW)
> >       ^~~~~~~~~~~~~~~~
> >   lib/gnulib/malloc/dynarray_resize.c:45:7: note: in expansion of macro 
> > ‘INT_MULTIPLY_WRAPV’
> >      if (INT_MULTIPLY_WRAPV (size, element_size, &new_size_bytes))
> >          ^~~~~~~~~~~~~~~~~~
> >   ...
>
> I don't get that, actually.  What OS/gcc?  It's fine with the gcc-11 I'm
> using here.

Does gcc-11 work with the configure mentioned above?

Anyway, Debian 9, arm-linux-gnueabihf-gcc (Debian 6.3.0-18) 6.3.0 20170516.

The GRUB INSTALL file says:

  The Requirements
  ================

  GRUB depends on some software packages installed into your system. If
  you don't have any of them, please obtain and install them before
  configuring the GRUB.

  * GCC 5.1.0 or later

So, even if it is old it is perfectly valid compiler according to the
GRUB docs.

Hmmm... What are the latest gnulib minimal compiler, linker, etc. requirements?

Daniel