Re: [PATCH v5 0/4] Update gnulib and drop some patches

[Glenn Washburn]

On Wed, 16 Feb 2022 16:41:38 -0500
Robbie Harwood <rharwood@redhat.com> wrote:

> Changes in this version:
> 
> - Include most _GL_* defines from gnulib.  Hopefully we do not need all their
>   prereq logic as well, but I don't know what the compilers we support are, so
>   please correct that if needed.
> 
> - Avoid creating empty #defines.
> 
> - Fix issues with building gnulib's allocation modules observed by Glenn.  The
>   tree now builds warning-free with default cflags for me.

Minor nit, in the future it would be nice to have the info from
--interdiff or --range-diff on follow-up patch series. This make its
easier to see what changed from the previous series.

I can confirm that this now successfully builds for me and is not
causing new test failures.

Tested-by: Glenn Washburn <development@efficientek.com>

Glenn

> 
> Be well,
> --Robbie
> 
> Robbie Harwood (4):
>   Use visual indentation in config.h.in
>   Drop gnulib fix-base64.patch
>   Drop gnulib no-abort.patch
>   Update gnulib version and drop most gnulib patches
> 
>  bootstrap                                     | 319 ++++++++++--------
>  bootstrap.conf                                |  21 +-
>  conf/Makefile.extra-dist                      |   8 -
>  config.h.in                                   | 112 ++++--
>  configure.ac                                  |   2 +-
>  grub-core/Makefile.core.def                   |   1 +
>  grub-core/disk/luks2.c                        |   4 +-
>  grub-core/lib/gnulib-patches/fix-base64.patch |  21 --
>  .../lib/gnulib-patches/fix-null-deref.patch   |  13 -
>  .../gnulib-patches/fix-null-state-deref.patch |  12 -
>  .../fix-regcomp-uninit-token.patch            |  15 -
>  .../fix-regexec-null-deref.patch              |  12 -
>  .../gnulib-patches/fix-uninit-structure.patch |  11 -
>  .../lib/gnulib-patches/fix-unused-value.patch |  14 -
>  grub-core/lib/gnulib-patches/no-abort.patch   |  26 --
>  grub-core/lib/posix_wrap/limits.h             |   6 +-
>  grub-core/lib/posix_wrap/sys/types.h          |   7 +-
>  grub-core/lib/xzembed/xz.h                    |   5 +-
>  include/grub/compiler.h                       |   4 +-
>  include/grub/list.h                           |   2 +-
>  20 files changed, 293 insertions(+), 322 deletions(-)
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-base64.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-null-deref.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-null-state-deref.patch
>  delete mode 100644 
> grub-core/lib/gnulib-patches/fix-regcomp-uninit-token.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-regexec-null-deref.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-uninit-structure.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-unused-value.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/no-abort.patch
>