Re: [PATCH v2 0/4] Update gnulib and drop patches

[Glenn Washburn]

On Wed, 26 Jan 2022 17:09:08 -0500
Robbie Harwood <rharwood@redhat.com> wrote:

> This patchset is an expansion of "Drop gnulib fix-base64.patch" and rolls us
> forward to current gnulib development head.  Not carrying patches means we
> don't have to maintain a gnulib tree (nor do downstream distros).  It also
> allows us to pull in static analyzer fixes that gnulib has applied.
> 
> I've attempted to address concerns from previous review about _GL_* stuff, but
> it's possible I've misunderstood the request there.
> 
> fix-width.patch has not merged upstream.  A version has been proposed, but
> would need significant rewrite.  It doesn't seem worth the effort to carry,
> and once this changeset merges to grub, it becomes easier to increment our
> gnulib version if something like it ever does merge there.

Thanks Robbie for updating gnulib, this is something I've been wanting
to get done. If I'm understanding you correctly, fix-width.patch is
being dropped but there is not replacement for what it did. How was
this patch functionally being used by GRUB? And what will the effects
be of dropping it? Looking at the patch maybe one of the places its
used is in GRUB's help command. If so, does that mean that line
wrapping when printing help will be affected?

Glenn

> 
> Be well,
> --Robbie
> 
> Robbie Harwood (4):
>   Use visual indentation in config.h.in
>   Drop gnulib fix-base64.patch
>   Drop gnulib no-abort.patch
>   Update gnulib version and drop all gnulib patches
> 
>  bootstrap                                     | 297 ++++++++++--------
>  bootstrap.conf                                |  14 +-
>  conf/Makefile.extra-dist                      |  10 -
>  config.h.in                                   |  78 +++--
>  configure.ac                                  |   2 +-
>  grub-core/Makefile.core.def                   |   1 +
>  grub-core/lib/gnulib-patches/fix-base64.patch |  21 --
>  .../lib/gnulib-patches/fix-null-deref.patch   |  13 -
>  .../gnulib-patches/fix-null-state-deref.patch |  12 -
>  .../fix-regcomp-uninit-token.patch            |  15 -
>  .../fix-regexec-null-deref.patch              |  12 -
>  .../gnulib-patches/fix-uninit-structure.patch |  11 -
>  .../lib/gnulib-patches/fix-unused-value.patch |  14 -
>  grub-core/lib/gnulib-patches/fix-width.patch  | 217 -------------
>  grub-core/lib/gnulib-patches/no-abort.patch   |  26 --
>  grub-core/lib/posix_wrap/sys/types.h          |   7 +-
>  grub-core/lib/xzembed/xz.h                    |   5 +-
>  17 files changed, 226 insertions(+), 529 deletions(-)
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-base64.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-null-deref.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-null-state-deref.patch
>  delete mode 100644 
> grub-core/lib/gnulib-patches/fix-regcomp-uninit-token.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-regexec-null-deref.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-uninit-structure.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-unused-value.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/fix-width.patch
>  delete mode 100644 grub-core/lib/gnulib-patches/no-abort.patch
>