[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Fix a couple issues in moddep parsing
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 0/2] Fix a couple issues in moddep parsing |
|
Date: |
Fri, 14 Jan 2022 16:06:48 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Jan 12, 2022 at 08:54:59PM -0600, Glenn Washburn wrote:
> The first patch fixes an OOB read bug and the second outputs a less confusing
> error to the user when the moddep.lst line is too long. Really it would be
> better to support lines of unlimited length, but I'm not motivated to add
> that.
> The condition under which these issues are triggered should never really
> happen
> because no module (currently) has enough dependencies to generate such long
> lines in moddep.lst. I was triggering this under some odd conditions where
> the all_video module dependency line contained all grub modules. So I think
> having a max length for moddep.lst lines is reasonable at this point.
For both Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...
Daniel