Re: [PATCH 3/4] luks2: set up dummy sector size during scan

[Josselin Poiret]

Hello everyone,

Fabian Vogt <fvogt@suse.de> writes:
> It looks like we have a third patch (series) for this feature meanwhile:
> [PATCH 0/2] Have LUKS2 cryptomounts be useable with grub-probe
>
> I CC'd the author, let's try to coordinate.
>
> Thanks,
> Fabian

Let me just say that I had not found this patch series while searching
beforehand.  Let me just recap what my patches do differently (in
relation to patches 3 and 4 of this series):

Because cheat-mounting cryptodisks only happens (from my understanding)
when pulling devmapper devices, we can simply ask the kernel for the dm
and dm-crypt parameters that it's opened with, and populate our
cheat-mounted device from that.  This completely circumvents the multiple
segments issue, as this will always yield the parameters corresponding
to the user-specified mountpoint of `grub-probe` or `grub-install`.

I also opted not to add a GRUB_DEV_ABSTRACTION_LUKS2 abstraction, so as
to reuse all existing code that supports LUKS1, although that can be
confusing.  We could simply rename GRUB_DEV_ABSTRACTION_LUKS1 to
GRUB_DEV_ABSTRACTION_CRYTODISK, as LUKS1 and LUKS2 only differ in how
they're unlocked, not in underlying algorithms.

What do you think?

-- 
Josselin Poiret