grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 0/9] Refactor/improve cryptomount data passing to crypto m


From: Daniel Kiper
Subject: Re: [PATCH v5 0/9] Refactor/improve cryptomount data passing to crypto modules
Date: Mon, 20 Dec 2021 23:40:10 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Thu, Dec 09, 2021 at 11:14:49AM -0600, Glenn Washburn wrote:
> Updates since v4:
> * Rework patch #2 to (hopefully) be easier to understand
> * Add more commentary to patch #2 commit message
> * Split previous patch #3 into three separate patches
>
> ---
> This patch series refactors the way cryptomount passes data to the crypto
> modules. Currently, the method has been by global variable and function call
> argument, neither of which are ideal. This method passes data via a
> grub_cryptomount_args struct, which can be added to over time as opposed to
> continually adding arguments to the cryptodisk recover_key (as is being
> proposed in the keyfile and detached header patches).

Whole patch series looks good to me. I am going to merge it no later
than on Thursday this week.

Patrick, could you do final check of these patches before I will apply them?

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]