[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/9] Refactor/improve cryptomount data passing to crypto m
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v5 0/9] Refactor/improve cryptomount data passing to crypto modules |
Date: |
Mon, 20 Dec 2021 23:40:10 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Dec 09, 2021 at 11:14:49AM -0600, Glenn Washburn wrote:
> Updates since v4:
> * Rework patch #2 to (hopefully) be easier to understand
> * Add more commentary to patch #2 commit message
> * Split previous patch #3 into three separate patches
>
> ---
> This patch series refactors the way cryptomount passes data to the crypto
> modules. Currently, the method has been by global variable and function call
> argument, neither of which are ideal. This method passes data via a
> grub_cryptomount_args struct, which can be added to over time as opposed to
> continually adding arguments to the cryptodisk recover_key (as is being
> proposed in the keyfile and detached header patches).
Whole patch series looks good to me. I am going to merge it no later
than on Thursday this week.
Patrick, could you do final check of these patches before I will apply them?
Daniel
- [PATCH v5 5/9] cryptodisk: Improve cryptomount -u error message, (continued)
- [PATCH v5 5/9] cryptodisk: Improve cryptomount -u error message, Glenn Washburn, 2021/12/09
- [PATCH v5 7/9] cryptodisk: Refactor password input out of crypto dev modules into cryptodisk, Glenn Washburn, 2021/12/09
- [PATCH v5 6/9] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules, Glenn Washburn, 2021/12/09
- [PATCH v5 8/9] cryptodisk: Move global variables into grub_cryptomount_args struct, Glenn Washburn, 2021/12/09
- [PATCH v5 9/9] cryptodisk: Improve handling of partition name in cryptomount password prompt, Glenn Washburn, 2021/12/09
- Re: [PATCH v5 0/9] Refactor/improve cryptomount data passing to crypto modules,
Daniel Kiper <=