grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 6/9] cryptodisk: Add infrastructure to pass data from cryp


From: Daniel Kiper
Subject: Re: [PATCH v5 6/9] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules
Date: Mon, 20 Dec 2021 23:18:29 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Thu, Dec 09, 2021 at 11:14:55AM -0600, Glenn Washburn wrote:
> Previously, the cryptomount arguments were passed by global variable and
> function call argument, neither of which are ideal. This change passes data
> via a grub_cryptomount_args struct, which can be added to over time as
> opposed to continually adding arguments to the cryptodisk scan and
> recover_key.
>
> As an example, passing a password as a cryptomount argument is implemented.
> However, the backends are not implemented, so testing this will return a not
> implemented error.
>
> Also, add comments to cryptomount argument parsing to make it more obvious
> which argument states are being handled.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]