Re: [PATCH] Drop gnulib fix-base64.patch

[Daniel Kiper]

On Tue, Dec 07, 2021 at 03:34:29PM -0500, Robbie Harwood wrote:
> Daniel Kiper <dkiper@net-space.pl> writes:
> > On Mon, Nov 29, 2021 at 06:21:46PM -0500, Robbie Harwood wrote:
> >> Daniel Kiper <dkiper@net-space.pl> writes:
> >>
> >> > Yeah, but I think it would require major overhaul. Does not it? If yes
> >> > then maybe we should consider move to the Kconfig or something like
> >> > that.
> >>
> >> Perhaps, but please don't mistake me as volunteering for build system
> >
> > I do not... I am not sure how you inferred I do.
> >
> >> hacking - I'm mostly just here to upstream patches :)
> >
> > Cool! I have just asked you to investigate how to improve your patch.
> > Currently I am not happy with it. I still hope you will send me some
> > proposals (I do not expect patches immediately; if you prefer just tell
> > me how do you want to fix the issue in better way). If I get them then
> > we can continue discussion...
>
> Sorry, I think I missed this - what are you unhappy about with this
> patch?

It tries to fix one specific issue and do not address other problems
which we have with the gnulib _GL_* constants. I would prefer to fix
them at once now. I hope this should not be difficult. In the worst case
we can copy _GL_* constants to config.h.in from config-util.h.in. Though
I would prefer to avoid this manual work if we are able to find quite
simple solution doing this automatically.

Daniel