Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

[Juergen Gross]

On 19/10/2018 17:10, Juergen Gross wrote:
> On 19/10/2018 14:48, Daniel Kiper wrote:
>> On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote:
>>> +  r = grub_xen_hypercall (__HYPERVISOR_hvm_op, HVMOP_get_param,
>>> +                     (grub_uint32_t) (&xhv), 0, 0, 0, 0);
>>
>> s/(grub_uint32_t) (&xhv)/(grub_uint32_t)(&xhv)/
>> Here and in the other patches...
> 
> Oh, I have seen lots of places where casts are followed by a blank. I
> thought this would be the preferred style.

Doing some greps I've found about 9000 casts with a blank between
(type) and casted value, but less than 3000 omitting the blank.

Is omitting the blank really preferred?


Juergen