Re: [PATCH v2 1/2] Import upstream zstd-1.3.6

[Daniel Kiper]

On Mon, Oct 08, 2018 at 04:06:20PM -0700, Nick Terrell wrote:
> Import zstd-1.3.6 from upstream [1]. Only the files need for decompression
> are imported.
>
> I used the latest zstd release, which includes patches [2] to build cleanly
> in GRUB.
>
> Upstream zstd commit hash: 4fa456d7f12f8b27bd3b2f5dfd4f46898cb31c24
> Upstream zstd commit name: Merge pull request #1354 from facebook/dev
>
> I've included the script used to import zstd-1.3.6 below.
>
> [1] https://github.com/facebook/zstd/releases/tag/v1.3.6
> [2] https://github.com/facebook/zstd/pull/1344
>
> ---
> #!/bin/sh

It seems to me that "-e" is missing here. Now you will see "SUCCESS!"
even if an error occurs.

> curl -L -O 
> https://github.com/facebook/zstd/releases/download/v1.3.6/zstd-1.3.6.tar.gz
> curl -L -O 
> https://github.com/facebook/zstd/releases/download/v1.3.6/zstd-1.3.6.tar.gz.sha256
> sha256sum --check zstd-1.3.6.tar.gz.sha256
> tar xzf zstd-1.3.6.tar.gz
>
> SRC_LIB="zstd-1.3.6/lib"
> DST_LIB="grub-core/lib/zstd"
> rm -rf $DST_LIB
> mkdir -p $DST_LIB
> cp $SRC_LIB/zstd.h $DST_LIB/
> cp $SRC_LIB/common/*.[hc] $DST_LIB/
> cp $SRC_LIB/decompress/*.[hc] $DST_LIB/
> rm $DST_LIB/{pool.[hc],threading.[hc]}
> rm -rf zstd-1.3.6*
> echo SUCCESS!
> ---
>
> Signed-off-by: Nick Terrell <address@hidden>
> ---
> v1 -> v2:
> - Switch to upstream zstd-1.3.6 rather than using the kernel zstd.
>
>  grub-core/lib/zstd/bitstream.h       |  458 ++++
>  grub-core/lib/zstd/compiler.h        |  133 ++
>  grub-core/lib/zstd/cpu.h             |  215 ++
>  grub-core/lib/zstd/debug.c           |   44 +
>  grub-core/lib/zstd/debug.h           |  123 +
>  grub-core/lib/zstd/entropy_common.c  |  236 ++
>  grub-core/lib/zstd/error_private.c   |   48 +
>  grub-core/lib/zstd/error_private.h   |   76 +
>  grub-core/lib/zstd/fse.h             |  708 ++++++
>  grub-core/lib/zstd/fse_decompress.c  |  309 +++
>  grub-core/lib/zstd/huf.h             |  334 +++
>  grub-core/lib/zstd/huf_decompress.c  | 1096 +++++++++
>  grub-core/lib/zstd/mem.h             |  374 ++++
>  grub-core/lib/zstd/up                |    1 +

I do not think that we need this file.

Otherwise LGTM.

Daniel