Re: [PATCH v3 2/8] verifiers: Framework core

[Daniel Kiper]

On Wed, Oct 03, 2018 at 01:55:08PM -0400, Ross Philipson wrote:
> On 10/03/2018 05:36 AM, Daniel Kiper wrote:

[...]

> > +struct grub_file_verifier grub_pubkey_verifier =
> > +  {
> > +    .name = "pgp",
> > +    .init = grub_pubkey_init,
> > +    .fini = grub_pubkey_fini,
> > +    .write = grub_pubkey_write,
> > +    .close = grub_pubkey_close,
> > +  };
>
> If I am reading this correctly, most of the first part of this is
> re-factoring the signature/pubkey verifier code to fit in with your new
> framework of verifiers, is that correct? So even though a bunch of code
> moved around and changed to some degree, it should be functionally
> basically the same?

That is the goal...

[...]

> > diff --git a/include/grub/file.h b/include/grub/file.h
> > index e2795d1..c55901c 100644
> > --- a/include/grub/file.h
> > +++ b/include/grub/file.h
> > @@ -170,7 +170,7 @@ extern grub_disk_read_hook_t 
> > EXPORT_VAR(grub_file_progress_hook);
> >  /* Filters with lower ID are executed first.  */
> >  typedef enum grub_file_filter_id
> >    {
> > -    GRUB_FILE_FILTER_PUBKEY,
> > +    GRUB_FILE_FILTER_VERIFY,
>
> I guess this kind of goes with my question above. Previously there was
> only one "verifier" and that was the pubkey verifier. Now the pubkey
> verifier will be one of many right?

Yep.

Daniel