Re: [PATCH] grub-install: Include all decompressor modules in pvxen core image.

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 07.12.2014 18:26, Andrei Borzenkov wrote:
> В Sun, 07 Dec 2014 18:18:47 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> 
>> On 30.11.2014 14:34, Ian Campbell wrote:
>>> On Sun, 2014-11-30 at 11:51 +0000, Ian Campbell wrote:
>>>> On Sun, 2014-11-30 at 14:31 +0300, Andrei Borzenkov wrote:
>>>>> if [ x$grub_platform = xxen ]; then
>>>>>   insmod xzio
>>>>> fi
>>>>
>>>> I think that could work.
>>>
>>> Indeed it does, so how about this instead of the patch at the start of
>>> the thread?
>>>
>> This should probably have been autoloaded.
> 
> File filters are not autoloaded and I do not see how it can really be
> done. OTOH unconditionally loading them may have unwanted side effect
> where we assumed files were not decompressed.
> 
In this particular case we could autoload based on signature to module map.
Probably it's a fair game since compressor can be uniquely determined
from magic.
Autoload could be restricted to xen linux loader.
> In this specific case extending grub-file to detect compression type
> used by kernel is probably OK.
> 
>>                                            Can you send me privately a
>> kernel you use, so I can reproduce your tests?
>>> >From f4199776eca80dfad4e9378a01ddb5866face3d7 Mon Sep 17 00:00:00 2001
>>> From: Ian Campbell <address@hidden>
>>> Date: Sun, 30 Nov 2014 12:12:52 +0000
>>> Subject: [PATCH] Arrange to insmod xzio when booting a kernel as a Xen guest
>>>
>>> This is needed in case the Linux kernel is compiled with CONFIG_KERNEL_XZ
>>> rather than CONFIG_KERNEL_GZ (gzio is already loaded by grub.cfg).
>>>
>>> Signed-off-by: Ian Campbell <address@hidden>
>>>
>>> Patch-Name: insmod-xzio-on-xen.patch
>>> ---
>>>  util/grub.d/10_linux.in | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in
>>> index 79fa03a..86e35f2 100644
>>> --- a/util/grub.d/10_linux.in
>>> +++ b/util/grub.d/10_linux.in
>>> @@ -150,6 +150,7 @@ linux_entry ()
>>>    fi
>>>  
>>>    echo "   insmod gzio" | sed "s/^/$submenu_indentation/"
>>> +  echo "   if [ x\$grub_platform = xxen ]; then insmod xzio; insmod 
>>> lzopio; fi" | sed "s/^/$submenu_indentation/"
>>>  
>>>    if [ x$dirname = x/ ]; then
>>>      if [ -z "${prepare_root_cache}" ]; then
>>>
>>
>>
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

signature.asc
Description: OpenPGP digital signature