Re: [PATCH] bash-completion: Remove obsolete usage of 'have' function

[Justin]

Andrei Borzenkov <arvidjaar <at> gmail.com> writes:

>
> В Fri,  5 Dec 2014 22:22:23 -0500
> Mike Gilbert <floppym <at> gentoo.org> пишет:
>
> > Recent versions of bash-completion do not provide the 'have' function.
>
> It still does as of today GIT.
>


# Backwards compatibility for compat completions that use have().
# @deprecated should no longer be used; generally not needed with dynamically
#             loaded completions, and _have is suitable for runtime use.
have()
{
    unset -v have
    _have  && have=yes
}

All major Linux distributions are using bash-completion version which support
dynamically loaded completions. Therefor we should cleanup shipped
bash-completions.

> > To keep things simple, this patch just removes it completely.
>
> No, that is not what was intended when 'have' was deprecated. You should
> put completion for each command in separate function which is then
> autoloaded on demand.

It was intended that you have one file (or a symlink) with the name of the
command which will be completed. That means dropping all have and pointing
symlinks with all support completions will fix it.

Or how would you update to recent bash-completion?


Justin