Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

[Christian Franke]

Robert Millan wrote:
> On Tue, Oct 23, 2007 at 09:06:16PM +0200, Christian Franke wrote:
>   
> > This patch fixes the broken evaluation of the E801 EISA memory map. The 
> > shift was too much, the high word is already shifted :-) The bug was 
> > hidden until the E820 memory map evaluation was broken due to the struct 
> > packing issue fixed in my last patch.
> >
> > The extra handling of "0x3C00" case is IMO not necessary. Regions are 
> > merged a few lines later.
> >
> > During testing, I added a primitive memory to detect such problems 
> > early. It was difficult to find why grub crashes during module load.
> >     
>
> Is this related to Cygwin?
>
>   

No. The EISA memory map bug would crash GRUB on all systems w/o E820 
memory map support.

The memory existence test is not necessary of course, but helped to 
check that memory map evaluation was finally working properly.

Christian