[PATCH v5 01/10] [libgroff]: Remove redundant checks.

[Alejandro Colomar]

ERANGE can only happen if strtol(3) returns either LONG_MIN or LONG_MAX.

Fixes: e4290210f2c1 ("Implement `SOURCE_DATE_EPOCH' for reproducible builds.")
Link: <https://savannah.gnu.org/bugs/?65451>
Cc: "G. Branden Robinson" <branden@debian.org>
Cc: Dave Kemper <saint.snit@gmail.com>
Cc: "James K. Lowden" <jklowden@schemamania.org>
Cc: Colin Watson <cjwatson@debian.org>
Cc: Werner LEMBERG <wl@gnu.org>
Cc: James Clark <jjc@jclark.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---
 src/libs/libgroff/curtime.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp
index 277755cab..490fc3018 100644
--- a/src/libs/libgroff/curtime.cpp
+++ b/src/libs/libgroff/curtime.cpp
@@ -42,8 +42,7 @@ struct tm *current_time()
     char *endptr;
     long epoch = strtol(source_date_epoch, &endptr, 10);
 
-    if ((errno == ERANGE && (epoch == LONG_MAX || epoch == LONG_MIN)) ||
-       (errno != 0 && epoch == 0))
+    if ((errno == ERANGE) || (errno != 0 && epoch == 0))
       fatal("$SOURCE_DATE_EPOCH: strtol: %1", strerror(errno));
     if (endptr == source_date_epoch)
       fatal("$SOURCE_DATE_EPOCH: no digits found: '%1'", endptr);
-- 
2.43.0

signature.asc
Description: PGP signature