groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 2/2] [troff]: Rewrite function in C.


From: Thorsten Glaser
Subject: Re: [PATCH v1 2/2] [troff]: Rewrite function in C.
Date: Fri, 4 Aug 2023 03:34:11 +0200 (CEST)

On Fri, 4 Aug 2023, Alejandro Colomar wrote:

>*  src/roff/troff/env.cpp (is_family_valid): The old code was
>   eyeball-bleeding.  This cuts 6 lines to 3, and each of them is
>   significantly simpler to read.  Remove the comments of how it could
>   be improved using modern C++, as I don't think it would improve much
>   vs this C implementation.
>
>Signed-off-by: Alejandro Colomar <alx@kernel.org>

lgtm: mirabilos <m@mirbsd.org>

bye,
//mirabilos
-- 
Stéphane, I actually don’t block Googlemail, they’re just too utterly
stupid to successfully deliver to me (or anyone else using Greylisting
and not whitelisting their ranges). Same for a few other providers such
as Hotmail. Some spammers (Yahoo) I do block.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]