emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix a possibly problematic string comparison


From: Rudolf Adamkovič
Subject: [PATCH] Fix a possibly problematic string comparison
Date: Sun, 27 Aug 2023 23:43:20 +0200

* lisp/org-table.el (org-table-make-reference): Replace 'eq' with
'string-empty-p' to resolve "Warning: 'eq' called with literal string
that may never match" issued on every 'make' invocation.
---
 lisp/org-table.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index f5a433c7d..b82749469 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -2864,7 +2864,7 @@ list, `literal' is for the format specifier L."
       (if lispp
          (if (eq lispp 'literal)
              elements
-           (if (and (eq elements "") (not keep-empty))
+           (if (and (string-empty-p elements) (not keep-empty))
                ""
              (prin1-to-string
               (if numbers (string-to-number elements) elements))))
-- 
2.41.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]