emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org.el: Respect org-extend-today-until in timestamps with ++


From: Valentin G. J. Herrmann
Subject: Re: [PATCH] org.el: Respect org-extend-today-until in timestamps with ++
Date: Sun, 13 Aug 2023 16:01:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0

In the attachments is a better version with tests that also addresses your latest critique.

On 13/08/2023 14.44, Ihor Radchenko wrote:
> Ihor Radchenko <yantar92@posteo.net> writes:
>
>>>               (while (or (= nshift 0)
>>> -                   (not (time-less-p nil time)))
>>> + (not (time-less-p nil (time-add time-to-extend time))))
>>
>> And this compares "now" with year 1970. Will always return nil.
>
> Hmm. I somehow missed `time-add'.
> However, this is still fishy.
> What if we have something like <2023-08-13 2:00 ++8h>?
> `org-extend-today-until' should probably be ignored then.

Attachment: 0001-org.el-Respect-org-extend-today-until-in-timestamps-.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]